A deal to celebrate, but will it lead to lasting peace?